Skip to content

feat(EventFactory): EventFactory and UserEventFactory #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(EventFactory): EventFactory and UserEventFactory #193

wants to merge 1 commit into from

Conversation

mariamjamal94
Copy link

Summary

  • UserEventFactory decouples ProjectConfig & provide the object to represent impression and conversion event.
  • EventFactory represents EventBatch after grouping imp/conv objects.

Test plan

  • Converted EventBuilder unit tests to EventFactory to make sure that all scenarios are covered to send payload to Server.

@aliabbasrizvi
Copy link
Contributor

@Mariamjamal32 I am going to request you to please sign our CLA mentioned in the CONTRIBUTING file.

@msohailhussain
Copy link
Contributor

@aliabbasrizvi can u plz. review #192 PR first. Meanwhile I ask Mariam to sign CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariamjamal94 @aliabbasrizvi @msohailhussain